Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usb_path to Z-Wave network_status websocket response #25617

Merged
merged 4 commits into from Aug 4, 2019

Conversation

@cgarwood
Copy link
Contributor

commented Jul 31, 2019

Description:

Adds the usb_path to the network_status websocket response for Z-Wave. Will be used to show the USB stick path in the Z-Wave configuration panel in the frontend.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@cgarwood cgarwood requested a review from home-assistant/z-wave as a code owner Jul 31, 2019

@project-bot project-bot bot added this to Needs review in Dev Jul 31, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 31, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Doesn't this conflate status and configuration ? Wouldn't it be nicer if we had 1 config call and 1 status call ? Then we could also make the status call a subscription, pushing the latest status to the frontend when it changes.

@cgarwood

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

That makes sense. I'll switch it to its own config command and have it return some additional data.

cgarwood added 2 commits Aug 1, 2019
@balloob
balloob approved these changes Aug 1, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 1, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

ok to merge when test added

@bachya bachya merged commit 0a87a4b into home-assistant:dev Aug 4, 2019

11 checks passed

CI Build #20190802.65 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 93.99%)
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 4, 2019

@lock lock bot locked and limited conversation to collaborators Aug 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.