Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacken top level *.py #25621

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@scop
Copy link
Contributor

commented Aug 1, 2019

Description:

SSIA.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@scop scop requested a review from home-assistant/core as a code owner Aug 1, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 1, 2019

@cgtobi
cgtobi approved these changes Aug 1, 2019
Copy link
Collaborator

left a comment

LGTM

Dev automation moved this from Needs review to Reviewer approved Aug 1, 2019

@cgtobi

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Strange, the validation failure should have nothing to do with the changes.

@scop

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

Actually, it does -- Black's quote changes break dependency extraction from setup.py. Will fix.

@@ -215,7 +215,7 @@ def core_requirements():
"""Gather core requirements out of setup.py."""
with open("setup.py") as inp:
reqs_raw = re.search(r"REQUIRES = \[(.*?)\]", inp.read(), re.S).group(1)
return re.findall(r"'(.*?)'", reqs_raw)
return [x[1] for x in re.findall(r"(['\"])(.*?)\1", reqs_raw)]

This comment has been minimized.

Copy link
@pvizeli

This comment has been minimized.

Copy link
@pvizeli

pvizeli Aug 1, 2019

Member

We should compile this on top and use the compiled constante

@balloob
balloob approved these changes Aug 1, 2019

@balloob balloob merged commit 6b22dbc into home-assistant:dev Aug 1, 2019

11 checks passed

CI Build #20190801.19 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 93.99%)
Details
codecov/project 93.99% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 1, 2019

@scop scop deleted the scop:black-toplevel branch Aug 1, 2019

@lock lock bot locked and limited conversation to collaborators Aug 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.