Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out empty results in history API #25633

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@balloob
Copy link
Member

commented Aug 1, 2019

Description:

Make sure that the history results never contain an empty state set for an entity.

CC @thomasloven

Related issue (if applicable): fixes issue reported by @VDRainer

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.97.0 milestone Aug 1, 2019

@balloob balloob requested a review from home-assistant/core as a code owner Aug 1, 2019

@ghost

This comment has been minimized.

Copy link

commented Aug 1, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (history) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@project-bot project-bot bot added this to Needs review in Dev Aug 1, 2019

@@ -628,3 +628,25 @@ def set_state(entity_id, state, **kwargs):
"/api/history/period/{}".format(dt_util.utcnow().isoformat())
)
assert response.status == 200


async def test_fetch_period_api_with_include_order(hass, hass_client):

This comment has been minimized.

Copy link
@andrewsayre

andrewsayre Aug 1, 2019

Member

Just to confirm - this is a test for something else, right? not the introduced functionality? I don't see it validating the results, other than HTTP status.

This comment has been minimized.

Copy link
@balloob

balloob Aug 1, 2019

Author Member

The request failed before my fix, because it assumed each entry for an entity had at least 1 state. It does indeed not validate the results.

Dev automation moved this from Needs review to Reviewer approved Aug 1, 2019

@balloob balloob merged commit 3649a1b into dev Aug 1, 2019

11 checks passed

CI Build #20190801.98 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c2556d9...bc95790
Details
codecov/project 93.99% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 1, 2019

@delete-merged-branch delete-merged-branch bot deleted the history-empty-results branch Aug 1, 2019

balloob added a commit that referenced this pull request Aug 1, 2019

@lock lock bot locked and limited conversation to collaborators Aug 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.