Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HmIP-SCI to Homematic IP Cloud, Fix HmIP-SWDM #25639

Merged
merged 3 commits into from Aug 1, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Aug 1, 2019

Description:

Add HmIP-SCI to Homematic IP Cloud
Fix HmIP-SWDM (fix in upstream lib, does not support sabotage)
Bump dependency to 0.10.10

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10033

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.

SukramJ added some commits Jul 17, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 1, 2019

@SukramJ SukramJ referenced this pull request Aug 1, 2019

Merged

Add HmIP-SCI to Homematic IP Cloud #10033

2 of 2 tasks complete

@SukramJ SukramJ force-pushed the SukramJ:HmIP-SCI branch from d128295 to 19017b4 Aug 1, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 1, 2019

@andrewsayre andrewsayre merged commit 8a57255 into home-assistant:dev Aug 1, 2019

11 checks passed

CI Build #20190801.123 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 35400b0...19017b4
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 1, 2019

@SukramJ SukramJ deleted the SukramJ:HmIP-SCI branch Aug 2, 2019

@lock lock bot locked and limited conversation to collaborators Aug 3, 2019

@amelchio amelchio added this to the 0.97.0 milestone Aug 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.