Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PRESET_AWAY to HomematicIP Cloud climate #25641

merged 2 commits into from Aug 3, 2019


Copy link

commented Aug 1, 2019


Add PRESET_AWAY to HomematicIP Cloud.
Vacation can be set by a call service (homematicip_cloud.activate_vacation), and will now displayed by the individual climate entity.

This PR fixes also the missing refresh for HOME.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@project-bot project-bot bot added this to Needs review in Dev Aug 1, 2019

@SukramJ SukramJ force-pushed the SukramJ:hmip-away branch from 142dc09 to 2a4f863 Aug 1, 2019

SukramJ added some commits Aug 1, 2019

@SukramJ SukramJ force-pushed the SukramJ:hmip-away branch from f75b2cb to a1ba1ec Aug 2, 2019

@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Aug 2, 2019

@SukramJ SukramJ changed the title Add PRESET_AWAY to HomematicIP Cloud Add PRESET_AWAY to HomematicIP Cloud climate Aug 3, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 3, 2019


pvizeli approved these changes Aug 3, 2019

@pvizeli pvizeli added this to the 0.97.0 milestone Aug 3, 2019

@pvizeli pvizeli merged commit 73f5575 into home-assistant:dev Aug 3, 2019

11 checks passed

CI Build #20190802.18 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
codecov/project 94.01% (target 90%)

Dev automation moved this from Reviewer approved to Done Aug 3, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

Hi @pvizeli, @balloob,
if you want to add this PR to milestone 0.97, then you need to add also #25639 to the milestone.
Otherwise a device (HmIP-SWDM) will be lost due to a reorg in the upstream lib. It is also a small PR.

@SukramJ SukramJ deleted the SukramJ:hmip-away branch Aug 3, 2019

@lock lock bot locked and limited conversation to collaborators Aug 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.