Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nest preset that is both away and eco #25643

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@balloob
Copy link
Member

commented Aug 1, 2019

Description:

Add a new preset for Nest to be away and in eco mode.

Related issue (if applicable): fixes #25427

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@balloob balloob added this to the 0.97.0 milestone Aug 1, 2019

@balloob balloob requested a review from awarecan as a code owner Aug 1, 2019

@ghost ghost assigned awarecan Aug 1, 2019

@ghost

This comment has been minimized.

Copy link

commented Aug 1, 2019

Hey there @awarecan, mind taking a look at this pull request as its been labeled with a integration (nest) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@project-bot project-bot bot added this to Needs review in Dev Aug 1, 2019

@balloob balloob changed the title Add preset to be away and eco Add Nest preset that is both away and eco Aug 1, 2019

@andrewsayre
Copy link
Member

left a comment

Seems hacky, but it works and fits our schema.

Dev automation moved this from Needs review to Reviewer approved Aug 1, 2019

@andrewsayre andrewsayre merged commit b5e2962 into dev Aug 1, 2019

11 checks passed

CI Build #20190801.133 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 35400b0...3853c9e
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 1, 2019

@delete-merged-branch delete-merged-branch bot deleted the nest-eco-and-away branch Aug 1, 2019

@lock lock bot locked and limited conversation to collaborators Aug 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.