Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert flux_led to 0.89 #25653

Merged
merged 6 commits into from Aug 2, 2019

Conversation

@amelchio
Copy link
Contributor

commented Aug 2, 2019

Description:

This reverts three previous flux_led PRs:

  • #20733 – which addressed a real bug but unfortunately broke other setups.
  • #22210 – which cleaned up some of the #20733 breakage but not all of it. @autinerd has since been MIA.
  • #25503 – which was merged prematurely but only to beta. I believe @yeralin is working on completing it.

The reverts bring flux_led back to the 0.89 level, as suggested in #22161 (comment). This includes the bug that #20733 tried to fix but I think it has become clear that it must be fixed in a different way.

I kept in a single fix that seems unrelated, #22161 (comment).

The commits cross both Black and The Great Migration so this does not exactly match the original PRs.

Related issue (if applicable): fixes #23322

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

amelchio added some commits Aug 2, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 2, 2019

@pvizeli

pvizeli approved these changes Aug 2, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 2, 2019

@amelchio amelchio added this to the 0.97.0 milestone Aug 2, 2019

@pvizeli pvizeli merged commit 2f7c57b into home-assistant:dev Aug 2, 2019

11 checks passed

CI Build #20190802.19 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 2, 2019

@lock lock bot locked and limited conversation to collaborators Aug 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.