Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ELECTRICITY_IMPORTED_TOTAL obis to dsmr #25655

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@johnnychicago
Copy link
Contributor

commented Aug 2, 2019

Description:

Guys, I've just added an obis to make this component pull in total meter reading from Luxembourg's somewhat-smart CREOS meters. I have tested this locally successfully. I do not know what tox tests are.

obis has been added to dsmr_parser here: ndokter/dsmr_parser@887dd3a

First commit, first pull request ever. Please go gentle on me :)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Hi @johnnychicago,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 2, 2019

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 2, 2019

@MartinHjelmare MartinHjelmare changed the title Added ELECTRICITY_IMPORTED_TOTAL obis to access Luxembourg's CREOS Sm… Add ELECTRICITY_IMPORTED_TOTAL obis to dsmr Aug 2, 2019

@MartinHjelmare
Copy link
Member

left a comment

Thanks!

Dev automation moved this from Needs review to Reviewer approved Aug 2, 2019

@MartinHjelmare MartinHjelmare merged commit 10adae4 into home-assistant:dev Aug 2, 2019

11 checks passed

CI Build #20190802.29 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing 77e4ff9...d73d00b
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 2, 2019

@lock lock bot locked and limited conversation to collaborators Aug 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.