Add ELECTRICITY_IMPORTED_TOTAL obis to dsmr #25655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @johnnychicago, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
probot-home-assistant
bot
added
integration: dsmr
small-pr
MartinHjelmare
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Guys, I've just added an obis to make this component pull in total meter reading from Luxembourg's somewhat-smart CREOS meters. I have tested this locally successfully. I do not know what tox tests are.
obis has been added to dsmr_parser here: ndokter/dsmr_parser@887dd3a
First commit, first pull request ever. Please go gentle on me :)
Checklist:
tox. Your PR cannot be merged unless tests pass