Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pydocstyle to 4.0.0, do not run in tox #25667

Merged
merged 3 commits into from Aug 4, 2019

Conversation

@scop
Copy link
Contributor

commented Aug 2, 2019

Description:

http://www.pydocstyle.org/en/4.0.0/release_notes.html#july-6th-2019

See individual commit messages for more info.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. (getting a seemingly unrelated error in travis)
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
scop added 3 commits Aug 2, 2019
tox: do not run pydocstyle
Does not seem to add any value over flake8-docstrings (and would have
needed a D202 exclusion).
@ghost

This comment has been minimized.

Copy link

commented Aug 2, 2019

Hey there @dgomes, mind taking a look at this pull request as its been labeled with a integration (filter) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@pvizeli
pvizeli approved these changes Aug 4, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 4, 2019

@pvizeli pvizeli merged commit 49a5dda into home-assistant:dev Aug 4, 2019

11 checks passed

CI Build #20190802.48 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.01%)
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 4, 2019

@scop scop deleted the scop:upgrade-pydocstyle branch Aug 5, 2019

@lock lock bot locked and limited conversation to collaborators Aug 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.