Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tado AIR_CONDITIONING module was not working propertly #25677

Merged
merged 13 commits into from Aug 12, 2019

Conversation

@ejaviga
Copy link
Contributor

commented Aug 3, 2019

When AIR_CONDITIONING is configured, some optional parameter needs to be specified.

ejaviga added 6 commits Jul 18, 2019
Tado AIR_CONDITIONING module was not working propertly
AIR_CONDITIONING modules differs from HEATING module int he parameters.
Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

# Conflicts:
#	homeassistant/components/tado/__init__.py
#	homeassistant/components/tado/climate.py
#	homeassistant/components/tado/sensor.py

@project-bot project-bot bot added this to Needs review in Dev Aug 3, 2019

ejaviga added 3 commits Aug 3, 2019
@ejaviga

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

Why I can't get 'CheckFormat' to pass ?¿?¿?
I get: "##[error]Bash exited with code '1'."
No clue how to fix ...

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

ejaviga added 4 commits Aug 10, 2019
TADO More AC functionality
Also Black formatting
@ejaviga

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

Both Heat and Air Conditioning working now ...

Captura de pantalla 2019-08-11 a las 17 52 48
Captura de pantalla 2019-08-11 a las 12 15 04

Dev automation moved this from Needs review to Reviewer approved Aug 12, 2019

@balloob balloob merged commit 5f0334d into home-assistant:dev Aug 12, 2019

11 checks passed

CI Build #20190811.12 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing d89e8ea...f77c193
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 12, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Thanks ! 🐬

@lock lock bot locked and limited conversation to collaborators Aug 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.