Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service to reload scenes from configuration.yaml #25680

Merged
merged 8 commits into from Aug 5, 2019

Conversation

@balloob
Copy link
Member

commented Aug 4, 2019

Description:

Add a new service scene.reload to reload scenes from configuration.yaml without restarting Home Assistant.

Pull request with documentation for home-assistant.io (if applicable): TBD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Aug 4, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 4, 2019

@ghost

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (homeassistant) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@ghost

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (scene) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob changed the title Allow reloading scenes Add service to reload scenes from configuration.yaml Aug 4, 2019

@balloob balloob referenced this pull request Aug 4, 2019

Open

Add reproduce state to all entity components #25681

1 of 17 tasks complete

pvizeli added some commits Aug 5, 2019

pvizeli and others added some commits Aug 5, 2019

Update homeassistant/components/homeassistant/scene.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

@pvizeli pvizeli added this to the 0.97.0 milestone Aug 5, 2019

@pvizeli

pvizeli approved these changes Aug 5, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 5, 2019

@pvizeli pvizeli merged commit 7a90808 into dev Aug 5, 2019

10 of 11 checks passed

codecov/patch 86.04% of diff hit (target 94.02%)
Details
CI Build #20190805.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 5, 2019

@delete-merged-branch delete-merged-branch bot deleted the reload-scene branch Aug 5, 2019

balloob added a commit that referenced this pull request Aug 6, 2019

Add service to reload scenes from configuration.yaml (#25680)
* Allow reloading scenes

* Update requirements

* address comments

* fix typing

* fix tests

* Update homeassistant/components/homeassistant/scene.py

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

* Address comments

@lock lock bot locked and limited conversation to collaborators Aug 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.