Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS4 Merge async_setup_platform into async_setup_entry #25689

Merged
merged 5 commits into from Aug 5, 2019

Conversation

@ktnrg45
Copy link
Contributor

commented Aug 4, 2019

Description:

Remove async_setup_platform method by merging it into async_setup_entry as config from configuration.yaml is not valid.

Related issue (if applicable): fixes #25665

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@project-bot project-bot bot added this to Needs review in Dev Aug 4, 2019

@ghost ghost assigned ktnrg45 Aug 4, 2019

ktnrg45 added 2 commits Aug 4, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

We can fix coverage by adding a test like this:

async def test_async_setup_platform():
"""Test setup platform does nothing (it uses config entries)."""
await media_player.async_setup_platform(None, None, None)

Dev automation moved this from Needs review to Reviewer approved Aug 4, 2019

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Can be merged when build passes.

@bachya bachya merged commit 069c186 into home-assistant:dev Aug 5, 2019

11 checks passed

CI Build #20190804.55 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.02%)
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 5, 2019

@lock lock bot locked and limited conversation to collaborators Aug 6, 2019

@ktnrg45 ktnrg45 deleted the ktnrg45:ps4-fix-error branch Aug 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.