Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - reverse connectivity logic #25691

merged 2 commits into from Aug 4, 2019


Copy link

commented Aug 4, 2019

Breaking Change:


@arsaboo pointed out inconsistencies with other definitions of connectivity in HASS. So I'm reversing the logic. This also puts it inline with how the POE switch represents on/off state in component.

Related issue (if applicable): fixes #

Pull request with documentation for (if applicable): home-assistant/< PR number goes here>

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 added this to the 0.97.0 milestone Aug 4, 2019

@Kane610 Kane610 self-assigned this Aug 4, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 4, 2019

@Kane610 Kane610 merged commit 5762917 into home-assistant:dev Aug 4, 2019

10 of 11 checks passed

codecov/patch 33.33% of diff hit (target 94.02%)
CI Build #20190804.25 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/project 94.02% (target 90%)

Dev automation moved this from Needs review to Done Aug 4, 2019

@Kane610 Kane610 deleted the Kane610:unifi-revert-block-switch-logic branch Aug 4, 2019

balloob added a commit that referenced this pull request Aug 5, 2019

UniFi - reverse connectivity logic (#25691)
* Make connectivity control in line with other implementations

@lock lock bot locked and limited conversation to collaborators Aug 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.