Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Aux Heat" support for Zwave Climate #25694

Merged
merged 5 commits into from Aug 7, 2019

Conversation

@eyager1
Copy link
Contributor

commented Aug 4, 2019

Breaking Change:

Description:

For some zwave thermostats such as the Gocontrol GC-TBZ48, "Heat" mode is currently inoperable because "Aux Heat" has also been been mapped as HVAC_MODE_HEAT.
This PR will implement Aux Mode support and resolve the mapping conflict with the "Aux Heat" mode.

Related issue (if applicable): fixes #25692
Pull request with documentation for home-assistant.io (if applicable):

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@eyager1 eyager1 requested a review from home-assistant/z-wave as a code owner Aug 4, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 4, 2019

@ghost

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@pvizeli
Copy link
Member

left a comment

Please handle aux heat corretly instead to workaround it

eyager1 added 2 commits Aug 6, 2019

@eyager1 eyager1 changed the title Remove "Aux Heat" from Zwave climate mappings Implement "Aux Heat" support for Zwave Climate Aug 6, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Pascal is correct. Aux heat should use the Aux heat methods: https://developers.home-assistant.io/docs/en/entity_climate.html#control-auxiliary-heater

@eyager1

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Pascal is correct. Aux heat should use the Aux heat methods: https://developers.home-assistant.io/docs/en/entity_climate.html#control-auxiliary-heater

I have recently updated this PR to add an implementation of this feature.

eyager1 added 2 commits Aug 6, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 7, 2019

@balloob
balloob approved these changes Aug 7, 2019
Copy link
Member

left a comment

Looks good!

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Sorry, missed that. This looks good!

@balloob balloob merged commit 506350d into home-assistant:dev Aug 7, 2019

7 of 9 checks passed

CI Build #20190806.43 had test failures
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 7, 2019

@lock lock bot locked and limited conversation to collaborators Aug 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.