Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unique_id in ZHA cluster channels #25707

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@dmulcahey
Copy link
Contributor

commented Aug 5, 2019

Breaking Change:

This change fixes unique id's that weren't stable. They could change when nwk addresses of nodes changed. Anyone who opted to use unique_id on events will have to update their automations to account for the change.

Previous format:
unique_id=0x0b64:1:0x0006

New format:
unique_id=00:0d:6f:00:0e:c8:d4:e7:1:0x0006

Description:

This PR corrects a stability issue with unique_id on cluster channels. If a node received a new nwk address the unique_id would change. This PR changes the unique_id to use the ieee address instead of the nwk address. The ieee address is static and therefore the unique_id will be stable now.

Previous format:
unique_id=0x0b64:1:0x0006

New format:
unique_id=00:0d:6f:00:0e:c8:d4:e7:1:0x0006

**Related issue (if applicable):
Issue #25700 may be related but based on the symptoms I do not expect this PR to fix the issue experienced in the ticket.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@ghost

This comment has been minimized.

Copy link

commented Aug 5, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@project-bot project-bot bot added this to Needs review in Dev Aug 5, 2019

@dmulcahey dmulcahey changed the title Fix unique id in ZHA cluster channels Fix unique_id in ZHA cluster channels Aug 5, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 5, 2019

@Adminiuga
Copy link
Contributor

left a comment

Looks good.

@Adminiuga Adminiuga merged commit ac5fcff into home-assistant:dev Aug 5, 2019

9 checks passed

CI Build #20190805.18 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 5, 2019

@lock lock bot locked and limited conversation to collaborators Aug 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.