Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump incomfort client to 0.3.1 #25731

merged 1 commit into from Aug 6, 2019


Copy link

commented Aug 6, 2019


Bump the incomfort client to v0.3.1

Related issue (if applicable): fixes #25295

Pull request with documentation for (if applicable): N/A

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 6, 2019

@ghost ghost assigned zxdavb Aug 6, 2019

@zxdavb zxdavb requested a review from MartinHjelmare Aug 6, 2019

@zxdavb zxdavb marked this pull request as ready for review Aug 6, 2019

@MartinHjelmare MartinHjelmare changed the title bump incomfort client to fix #25295 Bump incomfort client to 0.3.1 Aug 6, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 6, 2019

@andrewsayre andrewsayre merged commit a76bb5e into home-assistant:dev Aug 6, 2019

11 checks passed

CI Build #20190806.19 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9e8df93...68e34b3
codecov/project 94.01% (target 90%)

Dev automation moved this from Reviewer approved to Done Aug 6, 2019


This comment has been minimized.

Copy link

commented Aug 6, 2019

@zxdavb should we tag this for 97? Feel free to tag bug fixes during beta for release.


This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@balloob, yes, would be good for 0.97 (still trying to get used to my new powers).

@zxdavb zxdavb deleted the zxdavb:bugfix_incomfort branch Aug 6, 2019

@balloob balloob added this to the 0.97.0 milestone Aug 6, 2019

balloob added a commit that referenced this pull request Aug 7, 2019

@balloob balloob referenced this pull request Aug 7, 2019


0.97.0 #25756

@lock lock bot locked and limited conversation to collaborators Aug 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.