Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert emulated hue changes #25732

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@balloob
Copy link
Member

commented Aug 6, 2019

Description:

Undo #25581 as it was introducing regressions, breaking support with certain models as per #25645.

Related issue (if applicable): fixes #25645

@project-bot project-bot bot added this to Needs review in Dev Aug 6, 2019

@balloob balloob added this to the 0.97.0 milestone Aug 6, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 6, 2019

@andrewsayre andrewsayre merged commit e24d3f1 into dev Aug 6, 2019

11 checks passed

CI Build #20190806.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 54d6acf...284096d
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 6, 2019

@delete-merged-branch delete-merged-branch bot deleted the undo-emulated-hue-change branch Aug 6, 2019

balloob added a commit that referenced this pull request Aug 7, 2019

@balloob balloob referenced this pull request Aug 7, 2019

Merged

0.97.0 #25756

@lock lock bot locked and limited conversation to collaborators Aug 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.