Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ring light platform #25733

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@rossdargan
Copy link
Contributor

commented Aug 6, 2019

Description:

Allows a flood light to be turned on and off

home-assistant/home-assistant.io#10064

Example entry for configuration.yaml (if applicable):

light:
  - platform: ring

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@rossdargan rossdargan referenced this pull request Aug 6, 2019
2 of 2 tasks complete

@project-bot project-bot bot moved this from Needs review to Second opinion wanted in Dev Aug 6, 2019

Dev automation moved this from Second opinion wanted to Reviewer approved Aug 6, 2019

@andrewsayre

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Looks good -- just need to address the build failure.

homeassistant/components/ring/light.py Outdated Show resolved Hide resolved
homeassistant/components/ring/light.py Outdated Show resolved Hide resolved
homeassistant/components/ring/light.py Outdated Show resolved Hide resolved
homeassistant/components/ring/light.py Show resolved Hide resolved

Dev automation moved this from Reviewer approved to Review in progress Aug 6, 2019

rossdargan added 2 commits Aug 6, 2019
@MartinHjelmare
Copy link
Member

left a comment

Good!

Dev automation moved this from Review in progress to Reviewer approved Aug 6, 2019

@balloob balloob merged commit 98eb8ef into home-assistant:dev Aug 6, 2019

11 checks passed

CI Build #20190806.29 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 98% of diff hit (target 94.01%)
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 6, 2019

@lock lock bot locked and limited conversation to collaborators Aug 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.