Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manufacturer specific channel for SmartThings. #25739

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@Adminiuga
Copy link
Contributor

commented Aug 7, 2019

Description:

Create manufacturer specific channel class for SmartThings Acceleration and Humidity sensors, to keep ZHA Core registry cleaner.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@project-bot project-bot bot added this to Needs review in Dev Aug 7, 2019

@ghost ghost assigned Adminiuga and dmulcahey Aug 7, 2019

@ghost

This comment has been minimized.

Copy link

commented Aug 7, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Adminiuga Adminiuga requested a review from dmulcahey Aug 7, 2019

@dmulcahey

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Good to go when the build passes!

Dev automation moved this from Needs review to Reviewer approved Aug 7, 2019

@Adminiuga Adminiuga merged commit c3c45f8 into home-assistant:dev Aug 7, 2019

9 checks passed

CI Build #20190807.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 7, 2019

@Adminiuga Adminiuga deleted the Adminiuga:ac/zha-smartthings-channel branch Aug 7, 2019

@lock lock bot locked and limited conversation to collaborators Aug 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.