Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates fedex integration (ADR-0004) #25745

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@frenck
Copy link
Member

commented Aug 7, 2019

Breaking Change:

The FedEx integration has been deprecated and is pending for removal in Home Assistant 0.100.0.

Description:

This PR deprecates the FedEx integration since it relies on web scraping to function.
As per ADR-0004 this is no longer allowed. The integration should now be deprecated for 2 releases before permanent removal.

Related issue (if applicable): #24332 #13131

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10070

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 7, 2019

@frenck frenck referenced this pull request Aug 7, 2019
2 of 2 tasks complete
@andrewsayre

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Can you update the breaking changes section to include instructions on how the user can continue to use this integration as a custom component?

"The fedex integration is deprecated and will be removed "
"in Home Assistant 0.100.0. For more information see ADR-0004:"
"https://github.com/home-assistant/architecture/blob/master/adr/0004-webscraping.md"
)

This comment has been minimized.

Copy link
@andrewsayre

andrewsayre Aug 7, 2019

Member

Suggest the string also mention they could copy the integration to a custom component if they desire to retain the functionality.

This comment has been minimized.

Copy link
@pvizeli

pvizeli Aug 7, 2019

Member

I think that is a good idea, but we should do that for all in blogpost.

Dev automation moved this from Needs review to Reviewer approved Aug 7, 2019

@pvizeli
pvizeli approved these changes Aug 7, 2019

@pvizeli pvizeli merged commit 84f464d into dev Aug 7, 2019

9 checks passed

CI Build #20190807.20 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 7, 2019

@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0122 branch Aug 7, 2019

@lock lock bot locked and limited conversation to collaborators Aug 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.