Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates srp_energy integration (ADR-0004) #25754

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@frenck
Copy link
Member

commented Aug 7, 2019

Breaking Change:

The SRP Energy integration has been deprecated and is pending for removal in Home Assistant 0.100.0.

Description:

This PR deprecates the SRP Energy integration since it relies on web scraping to function.
As per ADR-0004 this is no longer allowed. The integration should now be deprecated for 2 releases before permanent removal.

Evidence: https://github.com/lamoreauxlab/srpenergy-api-client-python/blob/master/srpenergy/client.py#L115

Related issue (if applicable): Closes #22538

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10072

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 7, 2019

@frenck frenck referenced this pull request Aug 7, 2019
2 of 2 tasks complete

Dev automation moved this from Needs review to Reviewer approved Aug 7, 2019

@pvizeli
pvizeli approved these changes Aug 7, 2019

@pvizeli pvizeli merged commit 07499fa into dev Aug 7, 2019

11 checks passed

CI Build #20190807.31 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 84f464d...fcb0596
Details
codecov/project 93.98% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 7, 2019

@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0126 branch Aug 7, 2019

@lock lock bot locked and limited conversation to collaborators Aug 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.