Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifi: Don't track unstable device attributes #25787

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Aug 8, 2019

Breaking Change:

7 attributes with a high rate of change were removed. There is no current workaround. The removed attributes were: ap_mac, bssid, ccm, channel, noise, rssi, and signal.

Description:

With the changes to the Unifi device_tracker in 0.97 (#24367), several unstable values are stored as attributes on each device. That change reverted behavior added in #15888 (from Issue #14745). This removes them to prevent recorder databases from filling up unnecessarily.

A future PR can be created to allow these to used in an opt-in way.

Related issue (if applicable): fixes #25782

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 8, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (unifi) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 8, 2019

@Kane610

Kane610 approved these changes Aug 8, 2019

Copy link
Contributor

left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Aug 8, 2019

@Kane610 Kane610 added this to the 0.97.1 milestone Aug 8, 2019

@andrewsayre

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

So this is a breaking change, right?

@Kane610

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

It was also missed. No attributes that's changing on this level should be on by default. They weren't supposed to be a part of the integration

@andrewsayre andrewsayre merged commit 8f2f770 into home-assistant:dev Aug 8, 2019

9 checks passed

CI Build #20190808.36 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 8, 2019

@jjlawren jjlawren deleted the jjlawren:unifi_remove_attributes branch Aug 8, 2019

balloob added a commit that referenced this pull request Aug 9, 2019

@balloob balloob referenced this pull request Aug 9, 2019

@lock lock bot locked and limited conversation to collaborators Aug 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.