Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ZHA device initialized logic #25796

Merged

Conversation

@dmulcahey
Copy link
Contributor

commented Aug 9, 2019

Description:

This PR refactors the device initialization logic in ZHA.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 9, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 9, 2019

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Aug 9, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

What's the goal of the refactor?

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

To make the logic easier to understand / follow. Tracing through this is always painful.

dmulcahey added 3 commits Aug 9, 2019

Dev automation moved this from Incoming to Reviewer approved Aug 9, 2019

@Adminiuga
Copy link
Contributor

left a comment

This looks good!

@dmulcahey dmulcahey marked this pull request as ready for review Aug 9, 2019

@Adminiuga Adminiuga merged commit fafd228 into home-assistant:dev Aug 9, 2019

11 checks passed

CI Build #20190809.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 4349b86...de37980
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 9, 2019

@lock lock bot locked and limited conversation to collaborators Aug 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.