Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update statistics sensor to disregard Unavailable values #25825

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@MatsNl
Copy link
Contributor

commented Aug 9, 2019

Exclude "unknown" values from statistics sensor, to avoid errors flooding log on offline devices

Checklist:

  • [x ] The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Update sensor.py
exclude "unknown" values from measurements

@MatsNl MatsNl requested a review from fabaff as a code owner Aug 9, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Hi @MatsNl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 9, 2019

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (statistics) you are listed as a codeowner for? Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 9, 2019

@MatsNl MatsNl changed the title Update sensor.py Update statistics sensor to disregard Unavailable values Aug 9, 2019

@balloob
Copy link
Member

left a comment

Makes sense.

Dev automation moved this from Needs review to Reviewer approved Aug 10, 2019

@balloob balloob merged commit a6f1773 into home-assistant:dev Aug 10, 2019

11 checks passed

CI Build #20190809.56 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch 100% of diff hit (target 94.01%)
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 10, 2019

@lock lock bot locked and limited conversation to collaborators Aug 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.