Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow components with empty list config (i.e. person) in packages #25827

Merged
merged 2 commits into from Aug 10, 2019

Conversation

@kellerza
Copy link
Member

commented Aug 9, 2019

Description:

Allow components with empty list config (i.e. person) in packages

Related issue (if applicable): fixes #23424

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

homeassistant:
  packages: !include_dir_named packages

packages\person.yaml

person:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@kellerza kellerza requested a review from home-assistant/core as a code owner Aug 9, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 9, 2019

@@ -745,7 +745,8 @@ def merge_log_err(hass):
await config_util.merge_packages_config(hass, config, packages)
assert config["api"] == {
"list_1": ["item_1", "item_2", "item_3"],
"list_2": ["item_1"],
"list_2": ["item_4"],
"list_3": [],

This comment has been minimized.

Copy link
@kellerza

kellerza Aug 9, 2019

Author Member

The key to the fix is here.... person: being an empty list was discarded, like this list3

Dev automation moved this from Needs review to Reviewer approved Aug 10, 2019

@balloob balloob merged commit 8b9d059 into home-assistant:dev Aug 10, 2019

11 checks passed

CI Build #20190810.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.01%)
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 10, 2019

@kellerza kellerza deleted the kellerza:person_merge branch Aug 10, 2019

@lock lock bot locked and limited conversation to collaborators Aug 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.