Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidtv to 0.0.22 #25848

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@JeffLIrion
Copy link
Contributor

commented Aug 10, 2019

Description:

Bump androidtv to 0.0.22. This fixes the validation for the state_detection_rules config entry.

More specifically, in the backend package I made it so that the androidtv.basetv.state_detection_rules_validator function returns the rules that it validates. Previously, it didn't return anything, and so Home Assistant would set the keys in the state_detection_rules parameter to None.

For example, this configuration:

- platform: androidtv
  name: Fire TV
  host: 192.168.0.10
  state_detection_rules:
    'com.netflix.ninja':
     - 'media_session_state'
     - 'standby'

would have been treated like this:

{'com.netflix.ninja': None}

instead of what it should have been:

{'com.netflix.ninja': ['media_session_state', 'standby']}

Related issue (if applicable): This fixes the validation for the state_detection_rules config entry.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

Dev automation moved this from Needs review to Reviewer approved Aug 10, 2019

@andrewsayre andrewsayre merged commit ff92307 into home-assistant:dev Aug 10, 2019

11 checks passed

CI Build #20190810.34 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing d89e8ea...bc2a767
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 10, 2019

@lock lock bot locked and limited conversation to collaborators Aug 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.