Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTGW domestic hot water enable option as service #25849

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@tcoenraad
Copy link
Contributor

commented Aug 10, 2019

Description:

This PR adds the service to OTGW to override and restore domestic hot water enabling/disabling

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10105

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 10, 2019

@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 10, 2019

Hey there @mvn23, mind taking a look at this pull request as its been labeled with a integration (opentherm_gw) you are listed as a codeowner for? Thanks!

@tcoenraad tcoenraad force-pushed the tcoenraad:add-otgw-dhw-ovrd branch from d2a8f5a to 3cd3f35 Aug 10, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

Hi @tcoenraad,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@tcoenraad tcoenraad force-pushed the tcoenraad:add-otgw-dhw-ovrd branch from 3cd3f35 to 9a5a883 Aug 10, 2019

@tcoenraad tcoenraad referenced this pull request Aug 10, 2019
2 of 2 tasks complete

@tcoenraad tcoenraad force-pushed the tcoenraad:add-otgw-dhw-ovrd branch from 9a5a883 to 3e2983b Aug 10, 2019

@home-assistant home-assistant deleted a comment from homeassistant Aug 10, 2019

@mvn23

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

Looks good to me 👍
Since you got started on the hot water support, would you consider implementing set_dhw_setpoint as well?

Dev automation moved this from Needs review to Review in progress Aug 11, 2019

@tcoenraad tcoenraad force-pushed the tcoenraad:add-otgw-dhw-ovrd branch from 3e2983b to 1b062f1 Aug 11, 2019

@tcoenraad

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

Looks good to me 👍
Since you got started on the hot water support, would you consider implementing set_dhw_setpoint as well?

I wasn't specifically considering that, as it seems my boiler is not supporting it 🤷‍♂

Dev automation moved this from Review in progress to Reviewer approved Aug 11, 2019

@MartinHjelmare MartinHjelmare merged commit 76b7818 into home-assistant:dev Aug 14, 2019

11 checks passed

CI Build #20190811.14 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b8460bb...1b062f1
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 14, 2019

@tcoenraad tcoenraad deleted the tcoenraad:add-otgw-dhw-ovrd branch Aug 14, 2019

zewelor added a commit to zewelor/home-assistant that referenced this pull request Aug 14, 2019

@lock lock bot locked and limited conversation to collaborators Aug 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.