Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Lutron RA2 occupancy sensors #25854

Merged
merged 4 commits into from Aug 15, 2019

Conversation

@achatham
Copy link
Contributor

commented Aug 10, 2019

Description:

Expose Lutron RA2 motion sensors

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10110

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 10, 2019

@achatham achatham force-pushed the achatham:lutron_motion branch 2 times, most recently from bc8d5ef to edb724e Aug 10, 2019

homeassistant/components/lutron/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/lutron/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/lutron/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/lutron/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/lutron/binary_sensor.py Outdated Show resolved Hide resolved

Dev automation moved this from Needs review to Review in progress Aug 11, 2019

@achatham achatham force-pushed the achatham:lutron_motion branch from edb724e to 7915680 Aug 11, 2019

@achatham achatham changed the title Expose Lutron RA2 motion sensors Expose Lutron RA2 occupancy sensors Aug 11, 2019

@achatham achatham referenced this pull request Aug 11, 2019
2 of 2 tasks complete
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Please don't squash commits after review has started to make it easier for readers to track changes.

@achatham achatham force-pushed the achatham:lutron_motion branch from 7915680 to ae78466 Aug 12, 2019

@achatham

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019


from . import LUTRON_CONTROLLER, LUTRON_DEVICES, LutronDevice

_LOGGER = logging.getLogger(__name__)

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Aug 12, 2019

Member

This isn't used.

@MartinHjelmare
Copy link
Member

left a comment

Good!

Dev automation moved this from Review in progress to Reviewer approved Aug 12, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Can be merged when build passes.

@benjimatt

This comment has been minimized.

Copy link

commented Aug 14, 2019

im assuming @achatham still needs to remove "import logging" since it is unused to pass the tests.....

By the way thanks for the hard work @achatham , cant wait for this to get implemented.

@achatham

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@cgarwood cgarwood merged commit 944ac4f into home-assistant:dev Aug 15, 2019

11 checks passed

CI Build #20190814.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing dc62671...b841c1a
Details
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 15, 2019

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.