Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproduce state support to input_boolean #25858

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@balloob
Copy link
Member

commented Aug 11, 2019

Description:

Add reproduce state support to input boolean.

Requires #25856 to be merged.

Related issue (if applicable): #25681

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Aug 11, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 11, 2019

@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 11, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (input_boolean) you are listed as a codeowner for? Thanks!

@balloob balloob referenced this pull request Aug 11, 2019
1 of 17 tasks complete
@@ -0,0 +1,50 @@
"""Repdroduce a light state."""

This comment has been minimized.

Copy link
@MartinHjelmare

Dev automation moved this from Needs review to Reviewer approved Aug 11, 2019

Dev automation moved this from Reviewer approved to Review in progress Aug 11, 2019

@balloob balloob force-pushed the reproduce-state-input-boolean branch from b6242b7 to 86fb688 Aug 12, 2019

@balloob

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Comments addressed.

@pvizeli pvizeli merged commit 172bbf8 into dev Aug 12, 2019

11 checks passed

CI Build #20190812.7 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.02%)
Details
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Review in progress to Done Aug 12, 2019

@delete-merged-branch delete-merged-branch bot deleted the reproduce-state-input-boolean branch Aug 12, 2019

@lock lock bot locked and limited conversation to collaborators Aug 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.