Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always populate hvac_modes in SmartThings climate platform #25859

Merged
merged 2 commits into from Aug 11, 2019

Conversation

@andrewsayre
Copy link
Member

commented Aug 11, 2019

Description:

Ensures that hvac_modes is always set to a list instance even if the ST device does not populate supportedThermostatModes.

Related issue (if applicable): fixes #25845

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

andrewsayre added some commits Aug 11, 2019

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Aug 11, 2019

@MartinHjelmare MartinHjelmare merged commit b8460bb into dev Aug 11, 2019

11 checks passed

CI Build #20190811.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.04%)
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix_smartthings_climate branch Aug 11, 2019

balloob added a commit that referenced this pull request Aug 12, 2019

Always populate hvac_modes in SmartThings climate platform (#25859)
* Always return list for hvac_modes

* Use climate constants
@balloob balloob referenced this pull request Aug 12, 2019

@lock lock bot locked and limited conversation to collaborators Aug 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.