Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tile Errors #25866

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@paraselene
Copy link
Contributor

commented Aug 11, 2019

Breaking Change:

No

Description:

Tile API use last_tile_state instead of tileState now

Related issue (if applicable): fixes #25815

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@paraselene paraselene requested a review from bachya as a code owner Aug 11, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

Hi @paraselene,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 11, 2019

Hey there @bachya, mind taking a look at this pull request as its been labeled with a integration (tile) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 11, 2019

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 11, 2019

@bachya
bachya approved these changes Aug 11, 2019
Copy link
Contributor

left a comment

Thank you! Can merge once CI passes.

Dev automation moved this from Needs review to Reviewer approved Aug 11, 2019

@paraselene

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

It's weird, Why the CI fails? I just modify some Strings only...

@bachya

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

It looks like the black check failed (meaning your new code isn't formatted properly) – please read this blog post: https://developers.home-assistant.io/blog/2019/07/31/black.html

@bachya

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@paraselene Looks like your linting is okay after all. Try to fetch the latest dev, rebase on top of that, and force push.

@paraselene paraselene force-pushed the paraselene:tile-api-update branch from 4250ea9 to adf3922 Aug 14, 2019

@paraselene paraselene force-pushed the paraselene:tile-api-update branch 2 times, most recently from ebe83ff to 3a0dd76 Aug 14, 2019

@paraselene

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@paraselene Looks like your linting is okay after all. Try to fetch the latest dev, rebase on top of that, and force push.

@bachya, it's weird, I rebase and force push again, it still fails the CI...

@project-bot project-bot bot moved this from Reviewer approved to Needs review in Dev Aug 14, 2019

@home-assistant home-assistant deleted a comment from homeassistant Aug 14, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Please run black from the project root and commit the changes.

black --fast homeassistant
@paraselene

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Please run black from the project root and commit the changes.

black --fast homeassistant

I tried to run and black and everything is fine.
All done! ✨ 🍰 ✨ 2528 files left unchanged.

@paraselene paraselene force-pushed the paraselene:tile-api-update branch from 3a0dd76 to e35faf5 Aug 15, 2019

@paraselene paraselene closed this Aug 15, 2019

@paraselene paraselene force-pushed the paraselene:tile-api-update branch from e35faf5 to b8bd97b Aug 15, 2019

Dev automation moved this from Needs review to Cancelled Aug 15, 2019

@paraselene paraselene reopened this Aug 15, 2019

Dev automation moved this from Cancelled to Needs review Aug 15, 2019

@bachya
bachya approved these changes Aug 15, 2019
Copy link
Contributor

left a comment

👍🏻

Dev automation moved this from Needs review to Reviewer approved Aug 15, 2019

@bachya bachya merged commit 3525728 into home-assistant:dev Aug 15, 2019

11 checks passed

CI Build #20190815.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b8bd97b...3bdc823
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 15, 2019

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.