Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volumio shuffle support #25871

Merged
merged 3 commits into from Aug 15, 2019

Conversation

@zewelor
Copy link
Contributor

commented Aug 11, 2019

Description:

Add set shuffle support to volumio media player integration

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

Dev automation moved this from Needs review to Review in progress Aug 11, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 12, 2019

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

zewelor and others added 3 commits Aug 11, 2019
Update homeassistant/components/volumio/media_player.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

@zewelor zewelor force-pushed the zewelor:support_shuffle_in_volumio branch from b22133b to 44cdc76 Aug 14, 2019

@zewelor

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

I've done wrong rebase and now many reviewers were requested :\

@MartinHjelmare MartinHjelmare removed request for home-assistant/core, Jc2k, robbiet480 and fabaff Aug 14, 2019

@cgarwood cgarwood merged commit 53ad33e into home-assistant:dev Aug 15, 2019

11 checks passed

CI Build #20190814.25 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 76b7818...44cdc76
Details
codecov/project 94.04% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 15, 2019

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019

@zewelor zewelor deleted the zewelor:support_shuffle_in_volumio branch Aug 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.