Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broadlink switch retry time option #25873

Merged
merged 4 commits into from Aug 16, 2019

Conversation

@zhumuht
Copy link
Contributor

commented Aug 11, 2019

Description:

add broadlink switch retry time in configuration
Sometimes the network is in bad condition, it will need more retry time.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10150

Example entry for configuration.yaml (if applicable):

  - platform: broadlink
    host: 192.168.1.167
    mac: 'B4:43:0D:B0:BC:1B'
    timeout: 30
    retry: 100
    friendly_name: batai_xiaochubao
    type: spminiplus

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

home-assistant/home-assistant.io#10150

@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 11, 2019

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (broadlink) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 11, 2019

Dev automation moved this from Needs review to Review in progress Aug 12, 2019

@zhumuht zhumuht force-pushed the zhumuht:conf_broadlink_retry branch from 5a0eb8e to 5783287 Aug 12, 2019

@zhumuht zhumuht force-pushed the zhumuht:conf_broadlink_retry branch from 5783287 to 6d14ec2 Aug 12, 2019

@MartinHjelmare MartinHjelmare changed the title add broadlink switch retry time in configuration Add broadlink switch retry time option Aug 13, 2019

@Danielhiversen
Copy link
Member

left a comment

Update the docs

@@ -34,7 +34,9 @@

DEFAULT_NAME = "Broadlink switch"
DEFAULT_TIMEOUT = 10
DEFAULT_RETRY = 3

This comment has been minimized.

Copy link
@Danielhiversen

Danielhiversen Aug 15, 2019

Member

Change it to 2 to keep the current behavior

This comment has been minimized.

Copy link
@zhumuht

zhumuht Aug 16, 2019

Author Contributor

done.

@zhumuht

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Update the docs
doc update is pulled request:
home-assistant/home-assistant.io#10150

@Danielhiversen
Copy link
Member

left a comment

Thanks

Dev automation moved this from Review in progress to Reviewer approved Aug 16, 2019

@Danielhiversen Danielhiversen merged commit 90d493a into home-assistant:dev Aug 16, 2019

11 checks passed

CI Build #20190816.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 44cdc76...38549a0
Details
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 16, 2019

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.