Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - Use state to know if device is online #25876

Merged

Conversation

@Kane610
Copy link
Contributor

commented Aug 11, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #25777

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 added this to the 0.97.2 milestone Aug 11, 2019

@Kane610 Kane610 self-assigned this Aug 11, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 11, 2019

@Kane610 Kane610 merged commit ab7db5f into home-assistant:dev Aug 11, 2019

10 of 11 checks passed

codecov/patch 66.66% of diff hit (target 94.04%)
Details
CI Build #20190811.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Needs review to Done Aug 11, 2019

@Kane610 Kane610 deleted the Kane610:unifi-device-attributes-unavailable branch Aug 11, 2019

balloob added a commit that referenced this pull request Aug 12, 2019

@balloob balloob referenced this pull request Aug 12, 2019

@lock lock bot locked and limited conversation to collaborators Aug 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.