Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check various base components #25878

merged 4 commits into from Aug 12, 2019


Copy link

commented Aug 11, 2019


Even with a very loose config like this, mypy can spot bugs our other tools don't. Once introduced, the checks can be tightened over time.


  • The code change is tested and works locally.
  • Local tests pass with tox (flake8 and mypy tested). Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
scop added 4 commits Aug 3, 2019

@scop scop requested review from dgomes, fabaff, kellerza, robbiet480 and home-assistant/core as code owners Aug 11, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 11, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 12, 2019

Copy link

left a comment

This looks good. I like that we can slowly introduce types like this 👍

@balloob balloob merged commit b738082 into home-assistant:dev Aug 12, 2019

11 checks passed

CI Build #20190811.37 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.04%)
codecov/project 94.04% (target 90%)

Dev automation moved this from Reviewer approved to Done Aug 12, 2019

@lock lock bot locked and limited conversation to collaborators Aug 13, 2019

@scop scop deleted the scop:typing-components branch Aug 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.