Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eq3bt: handle zero (closed valve) as a valid mode #25905

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@rytilahti
Copy link
Contributor

commented Aug 12, 2019

Description:

Fixes a regression introduced by the climate 1.0 changes. Zero is a completely valid mode (https://github.com/rytilahti/python-eq3bt/blob/master/eq3bt/eq3btsmart.py#L49).

Related issue (if applicable): fixes #25333

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dev automation moved this from Needs review to Reviewer approved Aug 13, 2019

@MartinHjelmare MartinHjelmare merged commit e0ea5f2 into home-assistant:dev Aug 13, 2019

11 checks passed

CI Build #20190812.38 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 61b687e...0c87b46
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 13, 2019

@rytilahti rytilahti deleted the rytilahti:fix_eq3bt_available branch Aug 13, 2019

@matthiasfaeth

This comment has been minimized.

Copy link

commented Aug 13, 2019

This fix works well. Thanks!

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.