Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path option to SABnzbd component #25908

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@cj-thornton
Copy link
Contributor

commented Aug 13, 2019

Description:

Adds an optional path setting to the SABnzbd component. This allows support for SABnzbd installs that use a different url_base (typically a reverse proxied configuration; see https://sabnzbd.org/wiki/configuration/2.3/special).

This change passes the path along to pysabnzbd as its web_root, which in turn uses the path to build up it's api URLs.

Rebased on top of dev now after #23846

Related issue (if applicable): #23846 which was approved/reviewed by @MartinHjelmare

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10124

Example entry for configuration.yaml (if applicable):

sabnzbd:
  path: /sabnzbd

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Add path option to SABnzbd component
Adds an optional `path` setting to the SABnzbd component. This allows support for SABnzbd installs that use a different `url_base` (typically a reverse proxied configuration; see https://sabnzbd.org/wiki/configuration/2.3/special).

This change passes the `path` along to pysabnzbd as its `web_root`, which in turn uses the path to build up it's api URLs.

@project-bot project-bot bot added this to Needs review in Dev Aug 13, 2019

@cj-thornton cj-thornton referenced this pull request Aug 13, 2019
2 of 2 tasks complete
@cj-thornton

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Looks like the CI builds and checks ran for an hour and exceeded the maximum time...re-run it perhaps?

Dev automation moved this from Needs review to Review in progress Aug 13, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Hi @cj-thornton,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@cj-thornton
Copy link
Contributor Author

left a comment

Updated with requested changes to use config.get for the webroot path

homeassistant/components/sabnzbd/__init__.py Outdated Show resolved Hide resolved

Dev automation moved this from Review in progress to Reviewer approved Aug 20, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Thanks!

@MartinHjelmare MartinHjelmare merged commit c5ca431 into home-assistant:dev Aug 20, 2019

12 checks passed

CI Build #20190819.30 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing 61b687e...03f6111
Details
codecov/project 94.02% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 20, 2019

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.