Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syncthru library to fix issue #25795 #25924

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@nielstron
Copy link
Contributor

commented Aug 13, 2019

Breaking Change:

None

Description:

Fixes the issue of not updating when unable to determine the state of the printer. Should now update the sensor regardless of non-offline state.

Related issue (if applicable): fixes #25795

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@nielstron nielstron force-pushed the nielstron:syncthru-patch branch from 4650b09 to 8c7f5bf Aug 13, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 13, 2019

@balloob balloob merged commit dc62671 into home-assistant:dev Aug 13, 2019

6 of 9 checks passed

CI Build #20190813.20 had test failures
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 13, 2019

zewelor added a commit to zewelor/home-assistant that referenced this pull request Aug 14, 2019

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.