Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add system options to config entries #25926
Related issue (if applicable): fixes #25764
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
We should also add the part in entity platform.
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/helpers/entity_platform.py#L336 is where we get/create an entry. Maybe we should pass the config entry instead of just the ID. The entity registry can then extract the option from the config entry.
MartinHjelmare left a comment •
A bit off topic:
Will this feature really solve the user story? I'm thinking the user has some devices that they want to track with entities and there are devices that they don't want to track. This option won't let them select between those easily.
Should we also add another function that let's the user manually add an entity from a list of discovered devices? This is out of scope of this PR.
Aug 18, 2019
9 of 11 checks passed
This seems to break onboarding:
MetFlowHandler is a data_entry_flow which doesn't have a default async_get_options_flow.
Thanks for the quick reply.
I agree that MetFlowHandler is a data_entry_flow but the module does register it as a config_entry (which is incorrect I assume). However, onboarding only broke after the introduction of this commit. Happy to open a separate issue but I'm guessing this should have been caught during testing?