Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uvloop from default install and warn about stream+shell_command #25929

Merged
merged 3 commits into from Aug 15, 2019

Conversation

@balloob
Copy link
Member

commented Aug 13, 2019

Description:

  • Remove uvloop from Dockerfiles
  • Add warning when requesting a stream not to use uvloop in combination with shell_command to avoid #22999

Related issue (if applicable): #22999

@balloob balloob requested a review from hunterjm as a code owner Aug 13, 2019

@balloob balloob requested a review from Aug 13, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 13, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 13, 2019

@balloob balloob merged commit 9b3aa9b into dev Aug 15, 2019

1 check passed

cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 15, 2019

@delete-merged-branch delete-merged-branch bot deleted the uvloop-warning branch Aug 15, 2019

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.