Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more Life360 errors in config flow & bump package to 4.1.1 #25930

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@pnbruckner
Copy link
Contributor

commented Aug 13, 2019

Description:

Life360's config flow did not handle some exceptions. Add code to handle these exceptions. Also bump the life360 package to 4.1.1 which filters urllib3 warnings from the log.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Aug 13, 2019

@balloob balloob merged commit bd8461b into home-assistant:dev Aug 14, 2019

10 of 12 checks passed

CI Build #20190813.28 had test failures
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing dc62671...48e0967
Details
codecov/project 94.04% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 14, 2019

@pnbruckner pnbruckner deleted the pnbruckner:life360-unknown-config-error branch Aug 14, 2019

@lock lock bot locked and limited conversation to collaborators Aug 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.