Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentherm_gw.climate to match Climate 1.0 #25931

Merged
merged 2 commits into from Oct 1, 2019

Conversation

@mvn23
Copy link
Contributor

commented Aug 13, 2019

Breaking Change:

Move climate entity state to hvac_action attribute to comply with climate 1.0. May break e.g. automations.

Description:

Update opentherm_gw.climate to match climate 1.0 as closely as possible.
Introduce hvac_action attribute for the current action of the boiler.
Entity state is read-only and reflects the last active hvac_action as we have no way to determine or change the actual thermostat mode setting (or even if the thermostat supports such a concept).
Preset is read-only, only PRESET_AWAY and PRESET_NONE are supported.
hvac_modes and preset_modes return empty lists to prevent attempts to change their related mode through the GUI.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • N/A
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Aug 18, 2019
@mvn23 mvn23 force-pushed the mvn23:opentherm_gw_climate branch from 722e2b1 to 15e2577 Aug 18, 2019
Dev automation moved this from Review in progress to Cancelled Aug 31, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Sorry, my browser was lagging and this was closed by mistake.

Dev automation moved this from Cancelled to Needs review Aug 31, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Are we happy with this?

@mvn23

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

Updated description to match functionality change in 15e2577.

@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Aug 31, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Please finish the review here.

Dev automation moved this from Review in progress to Reviewer approved Oct 1, 2019
@balloob
balloob approved these changes Oct 1, 2019
@balloob balloob merged commit 26d78ca into home-assistant:dev Oct 1, 2019
12 checks passed
12 checks passed
CI Build #20190831.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3463cc9...15e2577
Details
codecov/project 93.9% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 1, 2019
@mvn23 mvn23 deleted the mvn23:opentherm_gw_climate branch Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.