Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of library aio_geojson_geonetnz_quakes to v0.9 #25946

Merged

Conversation

@exxamalte
Copy link
Contributor

commented Aug 14, 2019

Breaking Change:

Description:

Update to aio_geojson_geonetnz_quakes v0.9 which depends on aio_geojson_client >= v0.7.

This fixes #25938 and also introduces a 10 second timeout when fetching data from the external feed.

Related issue (if applicable): fixes #25938

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable):

geonetnz_quakes:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

Dev automation moved this from Needs review to Reviewer approved Aug 14, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Thanks for quick response!

@MartinHjelmare MartinHjelmare merged commit 45bbd08 into home-assistant:dev Aug 14, 2019

12 checks passed

CI Build #20190814.17 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing dc62671...1292a63
Details
codecov/project 94.03% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 14, 2019

@exxamalte exxamalte deleted the exxamalte:fix-geonetnz-dependency branch Aug 14, 2019

zewelor added a commit to zewelor/home-assistant that referenced this pull request Aug 14, 2019

@lock lock bot locked and limited conversation to collaborators Aug 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.