Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete some incomplete type hints in helpers #25953

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@scop
Copy link
Contributor

commented Aug 14, 2019

Description:

Various helper type hint additions, allowing to remove some allow-incomplete-defs.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@scop scop requested a review from home-assistant/core as a code owner Aug 14, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 14, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 15, 2019

@balloob balloob merged commit aa508b5 into home-assistant:dev Aug 15, 2019

12 checks passed

CI Build #20190814.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.03%)
Details
codecov/project 94.03% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 15, 2019

@scop scop deleted the scop:typing-helpers branch Aug 15, 2019

@@ -94,6 +93,7 @@ def path(self):
"""
if self._load_task is None:
self._load_task = self.hass.async_add_job(self._async_load())

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Aug 15, 2019

Member

If we would use self.hass.async_create_task here instead of self.hass.async_add_job we wouldn't need the assert below.

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.