Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary db entries for metro_france #25957

Merged
merged 3 commits into from Aug 17, 2019

Conversation

@oncleben31
Copy link
Contributor

commented Aug 15, 2019

Description:

  • Fix #25911 : unnecessary entries in db from weather platform in Météo-France component.
  • Correct typo in log messages.

Related issue (if applicable): fixes #25911

**Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed: N/A

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dev automation moved this from Needs review to Review in progress Aug 15, 2019

@MartinHjelmare MartinHjelmare changed the title fix #25911 avoid db unnecessary entries for metro_france Fix unnecessary db entries for metro_france Aug 15, 2019

@@ -83,8 +84,13 @@ def attribution(self):
@property
def forecast(self):
"""Return the forecast."""
reftime = datetime.now().replace(hour=12, minute=00)
reftime = dt_util.as_utc(
dt_util.now(dt_util.get_time_zone("Europe/Paris")).replace(

This comment has been minimized.

Copy link
@balloob

balloob Aug 15, 2019

Member

Why would we use the Paris timezone and not the users timezone ?

This comment has been minimized.

Copy link
@oncleben31

oncleben31 Aug 17, 2019

Author Contributor

Your question has triggered a lot of brain activity. At first tough I was thinking the french weather service was providing forecast using Paris timezone.
After investigating weather forecast are done using the local area timezone.
Now I'm sure if I want correct timezone in the forecast it have to be manage on the package side. In the mean time I will us the user timezone assuming users are interesting mainly for forecast in their zone. Impact is low as currently the component support only day by day forecast.

Dev automation moved this from Review in progress to Reviewer approved Aug 17, 2019

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit ca74a23 into home-assistant:dev Aug 17, 2019

11 checks passed

CI Build #20190817.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a71e885...513eca5
Details
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 17, 2019

@oncleben31 oncleben31 deleted the oncleben31:meteofrance-issue25911 branch Aug 17, 2019

@lock lock bot locked and limited conversation to collaborators Aug 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.