Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to options flow #25969

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@balloob
Copy link
Member

commented Aug 15, 2019

Description:

Adding UI to options flow showed some small tweaks we should do to the options flow initialization.

CC @Kane610

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Aug 15, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 15, 2019

@Kane610
Copy link
Contributor

left a comment

Looks good to me! Nifty improvements

Dev automation moved this from Needs review to Reviewer approved Aug 15, 2019

@balloob balloob merged commit 8a1ab8c into dev Aug 15, 2019

12 checks passed

CI Build #20190815.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.04%)
Details
codecov/project 94.04% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 15, 2019

@delete-merged-branch delete-merged-branch bot deleted the flow-options branch Aug 15, 2019

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.