Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecobee preset and add climate mode back #25970

merged 2 commits into from Aug 16, 2019


Copy link

commented Aug 15, 2019


If no override is active, set current Ecobee preset to the activate climate program.

Add back the climate_mode attribute. This attribute represents the climate mode that is active or would be active if no override is active.

Related issue (if applicable): fixes #25833


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Dev automation moved this from Needs review to Reviewer approved Aug 16, 2019

@Danielhiversen Danielhiversen merged commit 23f2671 into dev Aug 16, 2019

11 checks passed

CI Build #20190815.34 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1bfe752...e579b1e
codecov/project 94.03% (target 90%)

Dev automation moved this from Reviewer approved to Done Aug 16, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-ecobee-preset branch Aug 16, 2019

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.