Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue tweak registered device type + discovery exception #25977

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@balloob
Copy link
Member

commented Aug 16, 2019

Description:

  • Fix registered device type to be according to the Hue API requirements
  • Fix where discovery of Hue could cause looking up a host key in context that didn't exist.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@balloob balloob requested a review from home-assistant/core as a code owner Aug 16, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 16, 2019

@balloob balloob merged commit 57ef721 into dev Aug 16, 2019

10 of 11 checks passed

codecov/patch 80% of diff hit (target 94.03%)
Details
CI Build #20190816.44 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Needs review to Done Aug 16, 2019

@delete-merged-branch delete-merged-branch bot deleted the hue-improv branch Aug 16, 2019

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
2 participants
You can’t perform that action at this time.