Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlalchemy to 1.3.7 #25997

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@fabaff
Copy link
Member

commented Aug 16, 2019

Description:

Changelog: https://docs.sqlalchemy.org/en/13/changelog/changelog_13.html#change-1.3.7

Example entry for configuration.yaml (if applicable):

recoder:

sensor:
  - platform: sql
    queries:
      - name: Sun state
        query: "SELECT * FROM states WHERE entity_id = 'sun.sun' ORDER BY state_id DESC LIMIT 1;"
        column: 'state'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@fabaff fabaff requested a review from dgomes as a code owner Aug 16, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 16, 2019

@pvizeli pvizeli merged commit 3307b44 into dev Aug 16, 2019

12 checks passed

CI Build #20190816.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 23f2671...7644d49
Details
codecov/project 94.04% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Needs review to Done Aug 16, 2019

@delete-merged-branch delete-merged-branch bot deleted the upgrade-sqlalchemy branch Aug 16, 2019

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.