Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bmw_connected_drive and eq3btsmart components by updating their dependencies #26012

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@OliverRepo
Copy link
Contributor

commented Aug 16, 2019

Breaking Change:

None

Description:

Fix bmw_connected_drive and eq3btsmart components by updating their dependencies

**Related issue (if applicable):

**Pull request with documentation for home-assistant.io (if applicable):

Example entry for configuration.yaml (if applicable):

None changed

Checklist:

  • [ x] The code change is tested and works locally.
  • [ x] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • [ x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [ x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@OliverRepo OliverRepo requested a review from rytilahti as a code owner Aug 16, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Hi @OliverRepo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Aug 16, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Thanks

@balloob balloob merged commit 9e52439 into home-assistant:dev Aug 16, 2019

12 checks passed

CI Build #20190816.56 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing 2a2f762...2bf841b
Details
codecov/project 94.03% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 16, 2019

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019

@pvizeli

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

We revert this PR because the version is missed on pypi now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.